Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Zero formating #386

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Fatal Zero formating #386

merged 4 commits into from
Sep 5, 2024

Conversation

pgert
Copy link
Contributor

@pgert pgert commented Jul 6, 2024

No description provided.

@Mrlinkwii
Copy link
Contributor

@pgert can you rebase the pr for me :)

@pgert
Copy link
Contributor Author

pgert commented Aug 30, 2024

You mean "squash" - No I can't.

Regarding the conflicts - What am I supposed to do?
Click on "Mark as resolved"?

@MrWrightyLC
Copy link
Contributor

MrWrightyLC commented Aug 30, 2024

You mean "squash" - No I can't.

Regarding the conflicts - What am I supposed to do? Click on "Mark as resolved"?

I hope this helps
First you need to resolve the conflicts (you can do it from your browser)

Then rebase the branch with Github Desktop

Finally you should be able to squash the commits.
(You don't need to do weird stuff like command line, so it should be easy.)

@pgert
Copy link
Contributor Author

pgert commented Sep 2, 2024

Does this do?
If not, I have to make a new PR.
GitHub Desktop is beyond me.

@F0bes F0bes removed the Needs Rebase label Sep 5, 2024
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that fixed the conflicts

@F0bes F0bes merged commit ef357da into PCSX2:main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants